Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update simple-project guide #543

Merged
merged 1 commit into from
Feb 18, 2019
Merged

docs: update simple-project guide #543

merged 1 commit into from
Feb 18, 2019

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Feb 16, 2019

No description provided.

@eysi09 eysi09 force-pushed the fix-simple-project-example branch from d108155 to 83709e7 Compare February 16, 2019 11:58
@eysi09 eysi09 mentioned this pull request Feb 16, 2019
Closed
thsig
thsig approved these changes Feb 16, 2019
View reviewed changes
Copy link
Collaborator

@thsig thsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Wrote a couple of minor comments.

docs/examples/simple-project.md Outdated Show resolved Hide resolved
docs/examples/simple-project.md Outdated Show resolved Hide resolved
@eysi09 eysi09 force-pushed the fix-simple-project-example branch from 83709e7 to 77e9fcd Compare February 16, 2019 20:00
@eysi09 eysi09 force-pushed the fix-simple-project-example branch from 77e9fcd to 852db3f Compare February 17, 2019 20:56
@thsig thsig merged commit 65ae444 into master Feb 18, 2019
@edvald edvald deleted the fix-simple-project-example branch April 2, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thsig thsig thsig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eysi09 @thsig