feat: change default git scan mode to repo
#5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `repo` scan mode loads the entire repo files into a tree structure and applies glob matching from there. This prevents a large amount of `git` subprocesses being spawned, and is much faster for large projects. Especially on Windows it has a large performance benefit due to Windows being slow at spawning subprocesses. We change this to be the default now, but it can always be overridden using the `GARDEN_GIT_SCAN_MODE=subtree` environment variable.
stefreak
previously approved these changes
Nov 13, 2023
stefreak
approved these changes
Nov 14, 2023
vvagaytsev
approved these changes
Nov 14, 2023
vvagaytsev
added a commit
that referenced
this pull request
Nov 28, 2023
Starting from #5399 the env variable `GARDEN_GIT_SCAN_MODE` defaults to `repo`. It means that it's already defined and the scan mode configured in the project config has no effect.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
* fix(git): prefer project-level repo scan mode over env variable Starting from #5399 the env variable `GARDEN_GIT_SCAN_MODE` defaults to `repo`. It means that it's already defined and the scan mode configured in the project config has no effect. * test(git): remove confusing describe wrapper Function `commonGitHandlerTests` already defines test suite for `getFiles` and another methods. * test(git): (quickfix) set vcs handlers consistently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
reposcan mode loads the entire repo files list into a tree structure and applies glob matching from there.This prevents a large amount of
gitsubprocesses being spawned, and is much faster for large projects.Especially on Windows it has a large performance benefit due to Windows being slow at spawning subprocesses.
We change this to be the default now, but it can always be overridden using the
GARDEN_GIT_SCAN_MODE=subtreeenvironment variable.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: