Misc log fixes #5330
Merged
Misc log fixes #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, action log entries created from an input log with 'fixLevel' set, would not inherit that level but instead default to the info level. This was only really noticeable around some edge in the web dashboard were logs that should've been verbose were rendered at the info level. This fixes that and adds corresponding tests.
Before this fix, requests for internal commands like _get-deploy-statuses weren't logged at all. Now we log them at the debug level which is useful for, well, debugging but also makes them visible in the web dashboard (if the appropriate level is set) where they originate from.
Before this fix, we'd "render" error logs before sending them to the server which meant that the "error" part was kept but the "msg" part was dropped. The user still sees the error but the message can be a bit chopped. This fixes that by sending the "msg" field as is and adding an "error" field to the payload as well that cloud handles separately.
thsig
approved these changes
Nov 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a handful of small logging issues I bumped into while using the web dashboard. See individual commits:
Commit 1:
fix(log): ensure action log inherits fixLevel
Before this fix, action log entries created from an input log with
'fixLevel' set, would not inherit that level but instead default to the
info level.
This was only really noticeable around some edge in the web dashboard
were logs that should've been verbose were rendered at the info level.
This fixes that and adds corresponding tests.
Commit 2:
improvement(server): log internal command requests at debug level
Before this fix, requests for internal commands like
_get-deploy-statuses weren't logged at all.
Now we log them at the debug level which is useful for, well, debugging
but also makes them visible in the web dashboard (if the appropriate
level is set) where they originate from.
Commit 3:
fix(cloud): correctly send error messages to server
Before this fix, we'd "render" error logs before sending them to
the server which meant that the "error" part was kept but the "msg" part
was dropped.
The user still sees the error but the message can be a bit chopped. This
fixes that by sending the "msg" field as is and adding an "error" field
to the payload as well that cloud handles separately.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: