Revert "fix: resolve multiline variables in kubernetes manifests correctly (#5270)" #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumailxyz
reviewed
Oct 20, 2023
| @@ -270,7 +270,7 @@ | |||
| "check-package-lock": "git diff-index --quiet HEAD -- package-lock.json || (echo 'package-lock.json is dirty!' && exit 1)", | |||
| "check-types": "tsc -p . --noEmit", | |||
| "clean": "shx rm -rf build", | |||
| "dev": "nodemon --watch src/template-string/*.pegjs --exec npm run build", | |||
| "dev": "nodemon --watch src/template-string/*.pegjs --exec yarn build", | |||
There was a problem hiding this comment.
let's fix this in a separate PR.
shumailxyz
approved these changes
Oct 20, 2023
|
@stefreak @shumailxyz this must be merged before the release to avoid the braking changes, right? |
|
@vvagaytsev Correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This reverts commit 946e74b.
We need to revert this commit, because despite the original behaviour is clearly unwanted, multiple users depend on it and we even recommend depending on it on it in our examples.
We will have to release a new major release
0.14with this breaking change.Which issue(s) this PR fixes:
Reopens #3899
Reopens #5266
Special notes for your reviewer: