Store action type in cloud #5278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
send-action-type-to-cloud
branch
from
c892b15 to
ff34b5d
Compare
eysi09
force-pushed
the
send-action-type-to-cloud
branch
3 times, most recently
from
5ce8929 to
5cf2ee6
Compare
eysi09
commented
Oct 20, 2023
eysi09
force-pushed
the
send-action-type-to-cloud
branch
from
cc5e511 to
fe203e4
Compare
eysi09
force-pushed
the
send-action-type-to-cloud
branch
from
fe203e4 to
79a3f17
Compare
thsig
previously approved these changes
Oct 23, 2023
eysi09
force-pushed
the
send-action-type-to-cloud
branch
from
40f6617 to
3dcd263
Compare
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
A previous commit in the same PR changed this behaviour. This simply reverts it back to what it was.
eysi09
force-pushed
the
send-action-type-to-cloud
branch
from
3dcd263 to
0d43380
Compare
|
Closing in favour of #5447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There's a bit of history here.
Garden has a concept of action kinds and action types, both of which we want to store in display in the dashboard UI.
Due to some legacy issues, were confusing the two and the API didn't support payload with the action type set correctly.
This has since been fixed in the API but be never updated the Core payload until.
However, there are older instances of the API still running that haven't been updated to support this payload yet, so we feature flag it for now. We should be able to move the feature flag very soon.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We should squash the commits before merging.