fix(api): visible and better error when fetching secrets 404s #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
better-404-errors-for-secrets
branch
from
34049f7 to
b4d43fd
Compare
eysi09
force-pushed
the
better-404-errors-for-secrets
branch
from
b4d43fd to
83e0992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, 404 errors that happened when fetching secrets were logged at a debug level and not visible to users.
This fixes that and improves the error message.
Related to #5275 because fixing that will reduce the chance of this error surfacing in the first place.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: