improvement: using a new release endpoint for self-update #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Would this PR fix #4893? |
mkhq
force-pushed
the
improvement-self-update-version-check
branch
from
0a6b643 to
6e0d9d0
Compare
TimBeyer
previously approved these changes
Oct 12, 2023
twelvemo
reviewed
Oct 13, 2023
| }) | ||
|
|
||
| it(`aborts cleanly if desired version isn't found`, async () => { | ||
| const scope = nock("https://get.garden.io") | ||
| scope.get("/releases/latest").reply(200, { tag_name: "0.13.0" }) | ||
|
|
There was a problem hiding this comment.
Why would 0.13.0 not exist?
There was a problem hiding this comment.
The test is for checking that foo cannot be downloaded. It resolves to a local server with the files in the data/self-update directory.
twelvemo
approved these changes
Oct 13, 2023
mkhq
added a commit
that referenced
this pull request
Oct 15, 2023
* improvement: using a new release endpoint for self-update * test: fixed self-update tests to mock the release endpoint * docs: architecture flag in self-update command * improvement: better error handling when retrieving releases * test: releases endpoint failure and clarifying comments on desired version --------- Co-authored-by: Anna Mager <[email protected]>
mkhq
added a commit
that referenced
this pull request
Oct 15, 2023
* improvement: using a new release endpoint for self-update * test: fixed self-update tests to mock the release endpoint * docs: architecture flag in self-update command * improvement: better error handling when retrieving releases * test: releases endpoint failure and clarifying comments on desired version --------- Co-authored-by: Anna Mager <[email protected]>
mkhq
added a commit
that referenced
this pull request
Oct 16, 2023
#5236) * improvement: using a new release endpoint for self-update (#5229) * improvement: using a new release endpoint for self-update * test: fixed self-update tests to mock the release endpoint * docs: architecture flag in self-update command * improvement: better error handling when retrieving releases * test: releases endpoint failure and clarifying comments on desired version --------- Co-authored-by: Anna Mager <[email protected]> * fix: docs base url --------- Co-authored-by: Anna Mager <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update to use a new endpoint to check for releases.
Which issue(s) this PR fixes:
Fixes #4893
Special notes for your reviewer: