Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ephemeral kubernetes plugin documentation #5195

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

twelvemo
Copy link
Collaborator

@twelvemo twelvemo commented Oct 5, 2023

What this PR does / why we need it:
Updates the ephemeral-k8s plugin docs to reflect the step-by-step nature of the plugin guide section better.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@twelvemo twelvemo requested review from shumailxyz and eysi09 October 5, 2023 14:50
@vvagaytsev
Copy link
Collaborator

The check-docs CI step has failed, could you check that, please?

@twelvemo
Copy link
Collaborator Author

twelvemo commented Oct 5, 2023

The check-docs CI step has failed, could you check that, please?

Thanks, forgot to re-generate the table of contents, fixed now.

Comment on lines +21 to +25

Each user is granted a maximum of **20 hours per month** of ephemeral cluster usage where each cluster has a maximum lifetime of **4 hours**. After this period, the cluster is automatically destroyed.

If you need to destroy the cluster before its maximum lifetime of 4 hours expires, you can do so by visiting your [web dashboard](https://app.garden.io) and selecting the option to destroy the ephemeral cluster from there. This allows you to release resources and terminate the cluster when it's no longer needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this fits better under the Ephemeral Kubernetes Guide page..

Listing limitations is fine at plugin level but the usage fits better on the guide page where we introduce the ephemeral kubernetes clusters.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need that guide?

Isn't it basically the same as walking through the plugin configuration?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we could get rid of this guide completely and ensure that all of this is included in plugin docs section.

The original idea was to give more highlight to ephemeral clusters and we decided to go with a guide for that purpose, and have detailed plugin configuration separately.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I get that.

But honestly I think we should keep this all under plugins for now.

We to want to err on consistency here and "train" people to look for things related to specific plugins under those sections, as opposed to some generic "Guides" section which currently is just all over the place.

We may change that structure at some point but until then, let's go for consistency.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the separate guide and added the one additional information from it about logging in to the web dashboard to the plugin section for ephemeral-kubernetes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...looks like there are some conflicts. I'll re-approve when resolved.

@twelvemo twelvemo requested a review from shumailxyz October 11, 2023 09:14
eysi09
eysi09 previously approved these changes Oct 11, 2023
@twelvemo twelvemo enabled auto-merge October 11, 2023 11:44
@twelvemo twelvemo added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit b0b1954 Oct 11, 2023
@twelvemo twelvemo deleted the update-docs-ephemeral-k8s branch October 11, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants