refactor(commands): remove create commands #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
remove-create-command
branch
from
273c35c to
4b61498
Compare
edvald
previously approved these changes
Jan 31, 2019
eysi09
force-pushed
the
remove-create-command
branch
from
4b61498 to
7ed46fe
Compare
eysi09
dismissed
edvald’s stale review
The docs still contain references to the create command.
BREAKING CHANGE: After this, the `create project` and `create module` commands will no longer be available. We're removing them for now because currently they're more confusing than they are useful. There's an open Github issue (#312) for properly implementing the "create" functionality.
eysi09
force-pushed
the
remove-create-command
branch
from
7ed46fe to
88d18d8
Compare
|
@edvald I dismissed your review since I noticed that the docs mention the |
edvald
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
After this, the
create projectandcreate modulecommands will nolonger be available. We're removing them for now because currently
they're more confusing than they are useful. There's an open Github
issue (#312) for properly implementing the "create" functionality.
Closes #492.