improvement(k8s): less verbose Run/Test errors #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now only log the full pod status on the debug log level and above when a Test or Run fails. This makes e.g. logs for failing Tests much less verbose by default, which should be a UX improvement.
vvagaytsev
reviewed
Aug 1, 2023
| moduleName, | ||
| version, | ||
| success: false, | ||
| startedAt, | ||
| completedAt: new Date(), | ||
| command, | ||
| exitCode: err.detail.exitCode, | ||
| errorDetail: err.detail, |
There was a problem hiding this comment.
We don't seem to read this explicitly in the caller-side code. But this will be printed to the error.log if the RunResult is not successful, right? Then it's definitely good to have more details in the logs.
vvagaytsev
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We now only log the full pod status on the debug log level and above when a Test or Run fails.
This makes e.g. logs for failing Tests much less verbose by default, which should be a UX improvement.