Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: update docker to v24.0.4 #4840

Merged
merged 1 commit into from
Jul 18, 2023
Merged

improvement: update docker to v24.0.4 #4840

merged 1 commit into from
Jul 18, 2023

Conversation

shumailxyz
Copy link
Contributor

@shumailxyz shumailxyz commented Jul 17, 2023

What this PR does / why we need it:
Updates the bundled Docker CLI from 20.10.9 to 24.0.4

Which issue(s) this PR fixes:

Fixes #4550

Special notes for your reviewer:
I couldn't find the SHA256 hashes of published packages officially, except for the windows binary (that we download from Github). So, i computed the SHA256 hashes manually of downloaded packages using shasum utility on mac.

@shumailxyz shumailxyz changed the title WIP: improvement: update docker to v24.0.4 improvement: update docker to v24.0.4 Jul 17, 2023
@shumailxyz shumailxyz marked this pull request as ready for review July 18, 2023 08:30
@shumailxyz shumailxyz requested a review from a team July 18, 2023 08:31
@shumailxyz
Copy link
Contributor Author

The test_dockerhub ci step failed 2 times (https://app.circleci.com/pipelines/github/garden-io/garden/19096/workflows/40dd263f-a8a0-42b1-a080-6b7cfcb0c96f/jobs/348110) however retrying resolved the issue. I believe those failures were not related to this change.

Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's back-port it to 0.12.

@shumailxyz shumailxyz merged commit eb12cea into main Jul 18, 2023
@shumailxyz shumailxyz deleted the update-docker branch July 18, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: update docker cli version
2 participants