file inclusion improvement + docs #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And throw helpful err if include and exclude statements overlap.
Walther
reviewed
Jul 7, 2023
| @@ -282,6 +283,18 @@ export const actionFromConfig = profileAsync(async function actionFromConfig({ | |||
|
|
|||
| const dependencies = dependenciesFromActionConfig(log, config, configsByKey, definition, templateContext) | |||
|
|
|||
| if (config.exclude?.includes("**/*")) { | |||
There was a problem hiding this comment.
should we have equals here instead of includes, in case of something like src/test/**/*?
There was a problem hiding this comment.
also, can we also add a test for this?
There was a problem hiding this comment.
config.exclude is an array of strings. It's checking if the array includes the exact match of "**/*"
There was a problem hiding this comment.
Writing tests was a good idea, found a bug in my original logic and removed some unwanted mutation
e4a9dce
and fix two bugs in the original logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits
related to #4763