improvement(k8s): ensure retries for most frequent kubectl calls
#4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The retry machinery uses some build-in checks to avoid retriying on any error. For `kubectl` custom `RetryOpts` are configured.
Orzelius
approved these changes
Jul 5, 2023
vvagaytsev
force-pushed
the
k3s-deploy-retry
branch
from
2332dcf to
2b29148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A follow-up PR for #4657. The original PR introduced an error message pattern to enable retries for k3s deployment errors. However, the retries didn't work because the deployment was done over the
kubectlcommand instead ofKubeApi.This PR wraps the most frequently used
kubectlcalls into the retry machinery that is used inKubeApi. The retry settings are customized to avoid too-long retry intervals.Which issue(s) this PR fixes:
Fixes #4460
Special notes for your reviewer:
See individual commits for details. Most of the changes are related to the dedicated refactoring commit 707d176.
I tested the fix twice with Google CloudShell and got no errors like in the original issue.