Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use var file when path is unresolved #4737

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

shumailxyz
Copy link
Contributor

What this PR does / why we need it:
in action pre-processing, only use the var files that are not template strings as those are resolved and populated later.

Which issue(s) this PR fixes:

Fixes #4702

Special notes for your reviewer:

@shumailxyz shumailxyz requested review from a team and vvagaytsev July 3, 2023 13:48
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you! 👍

@shumailxyz shumailxyz merged commit c323ccc into main Jul 3, 2023
@shumailxyz shumailxyz deleted the fix/template-env-varfile branch July 3, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

${environment.name} is not interpolated appropriately on deploy action
2 participants