refactor: add configureProvider plugin action #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
provider-refactor
branch
from
d198041 to
a9ffafc
Compare
edvald
force-pushed
the
hot-as-helm
branch
2 times, most recently
from
82b5d7d to
48f0375
Compare
edvald
force-pushed
the
provider-refactor
branch
from
a9ffafc to
d4162e2
Compare
thsig
approved these changes
Jan 25, 2019
|
|
||
| This can also be used to further specify the semantics of the provider, including dependencies. | ||
|
|
||
| This action is called on every execution of Garden, so it should return quickly and avoid doing |
There was a problem hiding this comment.
"on every execution of Garden" -> "on every execution of a Garden command"?
There was a problem hiding this comment.
How about
"Important: This action is called on most executions of Garden commands, so it should return quickly and avoid performing expensive processing or network calls."
|
|
||
| This can also be used to further specify the semantics of the provider, including dependencies. | ||
|
|
||
| This action is called on every execution of Garden, so it should return quickly and avoid doing |
| @@ -302,6 +321,9 @@ export const moduleActionDescriptions: | |||
| configuration and test configuration. Since services and tests are not specified using built-in | |||
| framework configuration fields, this action needs to specify those via the \`serviceConfigs\` and | |||
| \`testConfigs\` output keys. | |||
|
|
|||
| This action is called on every execution of Garden, so it should return quickly and avoid doing | |||
| @@ -287,6 +303,9 @@ export const moduleActionDescriptions: | |||
| should not specify the built-in fields (such as \`name\`, \`type\` and \`description\`). | |||
|
|
|||
| Used when auto-generating framework documentation. | |||
|
|
|||
| This action is called on every execution of Garden, so it should return quickly and avoid doing | |||
edvald
force-pushed
the
provider-refactor
branch
from
d4162e2 to
8f80c06
Compare
edvald
force-pushed
the
provider-refactor
branch
from
8f80c06 to
bdf6994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a larger branch I had, reworking the provider configuration and preparation mechanisms.