improvement(jib): allow using custom mvnd binaries
#4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
maven-locks
branch
6 times, most recently
from
bdb9505 to
85b7044
Compare
vvagaytsev
changed the title
jib-container plugin
vvagaytsev
force-pushed
the
maven-locks
branch
2 times, most recently
from
6d94c23 to
8d89f6f
Compare
vvagaytsev
changed the title
jib-container pluginmvnd and concurrent Maven builds
vvagaytsev
force-pushed
the
maven-locks
branch
2 times, most recently
from
0088629 to
4a2be53
Compare
Co-authored-by: Vladimir Vagaytsev <[email protected]>
vvagaytsev
changed the title
mvnd and concurrent Maven buildsmvnd binaries
Extracted some named types and helpers.
shumailxyz
approved these changes
Jun 23, 2023
|
Thanks, @shumailxyz! Testing the custom binary paths could be tricky. It requires some installation or downloading inside the test setup. We haven't test-covered any custom binary paths (Maven/Gradle/JDK) yet. I'll consider adding more tests in the next PR(s). |
|
Indeed that can be tricky. Let's add those separately and merge this. Edit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is the continuation of #3458. @ishantagarwal-x213235 huge thanks for creating the original PR! The proper support for concurrent builds will be implemented in a separate PR. This one allow to use custom
mvndand does some refactoring to make the further development and maintenance easier.Which issue(s) this PR fixes:
Special notes for your reviewer:
See individual commits for details.