chore: fire warnings on too long sync paths #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use action kind instead of "Module"
The `MUTAGEN_DATA_DIRECTORY` env variable has some implicit length limitations. Making it too long can cause mutagen failures with code `1` because of the Unix socket path length limit.
Orzelius
previously requested changes
Jun 9, 2023
Co-authored-by: Orzelius <[email protected]>
vvagaytsev
requested review from
Orzelius and
a team
and removed request for
a team and
Orzelius
shumailxyz
reviewed
Jun 9, 2023
Co-authored-by: Shumail Mohyuddin <[email protected]>
shumailxyz
approved these changes
Jun 9, 2023
shumailxyz
reviewed
Jun 9, 2023
| @@ -127,7 +127,7 @@ export async function syncToBuildSync(params: SyncToSharedBuildSyncParams) { | |||
| log, | |||
| key, | |||
| logSection: action.key(), | |||
| sourceDescription: `Module ${action.name} build path`, | |||
| sourceDescription: `${action.kind} ${action.name} build path`, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add some warnings on too-long sync paths to make the error details more informative. See individual commits for details.
Which issue(s) this PR fixes:
Mitigates #4527
Special notes for your reviewer:
I skipped the FAQ docs update. The warnings are visible well enough to users. And this problem occurs not that often for be a Frequently asked question :)
The commits will be squashed before the merge.