Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12 backport chore(deps): update AWS CLI, google cloud CLI and azure CLI to latest versions #4574

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

stefreak
Copy link
Member

@stefreak stefreak commented Jun 8, 2023

What this PR does / why we need it:
This backports the new methods of installing the latest versions of AWS CLI, azure CLI and Google Cloud CLI from the main branch (Bonsai).

Which issue(s) this PR fixes:

Fixes #4571 because there is an incompatibility between AWS CLI v1 and the latest helm versions.

Special notes for your reviewer:

… versions

This backports the new methods of installing the latest versions of AWS CLI, azure CLI and Google Cloud CLI from the main branch (Bonsai).

Fixes #4571 because there is an incompatibility between AWS CLI v1 and the latest helm versions.
@stefreak stefreak requested review from TimBeyer and vvagaytsev June 8, 2023 10:39
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Is there a way to test it?

@stefreak
Copy link
Member Author

stefreak commented Jun 8, 2023

@vvagaytsev basics are being tested by test-dockerhub in CircleCI.

But we do not have an integration test with EKS. I think adding that would make a lot of sense, but maybe in another PR.

@vvagaytsev
Copy link
Collaborator

@stefreak perfect, thank you so much! Let's merge this and make a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants