Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape rsync special characters in filenames on windows #4434

Merged
merged 1 commit into from
May 25, 2023

Conversation

Walther
Copy link
Contributor

@Walther Walther commented May 24, 2023

What this PR does / why we need it:

Filenames such as [id].vue can break our file synchronization (and hence builds and deploys) on Windows, where we use rsync

Which issue(s) this PR fixes:

Fixes #4018
Verified using a reproducible example on a Windows VM on Azure

Special notes for your reviewer:

https://linux.die.net/man/1/rsync section Include/Exclude Pattern Rules

rsync chooses between doing a simple string match and wildcard matching by checking if the pattern contains one of these three wildcard characters: oq*cq, oq?cq, and oq[cq .

Do we want to backport this to 0.12 (and cut a new release)?

@Walther Walther requested a review from a team May 24, 2023 15:54
Copy link
Contributor

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're freakin' legends for doing this windows legwork!

Do we want to backport this to 0.12 (and cut a new release)?

It shouldn't be too hard as it's a small change but I'll leave it up to you

@Walther Walther merged commit 4fbc5de into main May 25, 2023
@Walther Walther deleted the rsync-special-characters branch May 25, 2023 06:21
Walther added a commit that referenced this pull request May 25, 2023
Walther added a commit that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Garden ignoring nuxt dynamic route files
2 participants