Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13 clean up some skipped tests #4230

Merged
merged 5 commits into from
May 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -751,9 +751,7 @@ describe("kubernetes container deployment handlers", () => {
expect(status.state).to.eql("ready")
})

// TODO-G2: weird solver behaviour (action status not passed to deploy task process method)
// https://github.com/garden-io/garden/pull/3786#discussion_r1109433412
it.skip("should deploy a service referencing a volume module", async () => {
it("should deploy a service referencing a volume module", async () => {
const action = await resolveDeployAction("volume-reference")

const deployTask = new DeployTask({
Expand Down
1 change: 1 addition & 0 deletions core/test/unit/src/actions/action-configs-to-graph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ describe("actionConfigsToGraph", () => {
expect(action.isCompatible("test")).to.be.true
})

// TODO-G2
it.skip("correctly sets compatibleTypes for an action type with a base", async () => {
const graph = await actionConfigsToGraph({
garden,
Expand Down
4 changes: 0 additions & 4 deletions core/test/unit/src/server/core-event-stream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,4 @@ describe("CoreEventStream", () => {
// Wait for it to come up
await pEvent(garden.events, "serversUpdated", { timeout: 5000 })
})

it.skip("removes target hosts that are unreachable", async () => {
// TODO: let's see if we need this on top of the polling
})
})
5 changes: 1 addition & 4 deletions core/test/unit/src/tasks/deploy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

import tmp from "tmp-promise"
import execa from "execa"

import { ProjectConfig } from "../../../../src/config/project"
import { ConfigGraph } from "../../../../src/graph/config-graph"
Expand All @@ -16,7 +15,6 @@ import { DeployTask } from "../../../../src/tasks/deploy"
import { expect } from "chai"
import { createProjectConfig, makeTempDir, TestGarden } from "../../../helpers"
import { joi } from "../../../../src/config/common"
import { ActionConfig } from "../../../../src/actions/types"

describe("DeployTask", () => {
let tmpDir: tmp.DirectoryResult
Expand Down Expand Up @@ -147,8 +145,7 @@ describe("DeployTask", () => {
})

describe("resolveProcessDependencies", () => {
// TODO-G2B: this might make sense to implement but is not strictly needed
it.skip("should always return deploy action's dependencies having force = false", async () => {
it("should always return deploy action's dependencies having force = false", async () => {
const action = graph.getDeploy("test-deploy")

const forcedDeployTask = new DeployTask({
Expand Down
23 changes: 0 additions & 23 deletions e2e/test/pre-release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,29 +120,6 @@ describe("PreReleaseTests", () => {
})
}

if (project === "tasks") {
/*
* TODO: Re-enable once this has been debugged:
*
* TimeoutError: Knex: Timeout acquiring a connection. The pool is probably full.
* Are you missing a .transacting(trx) call?
*/
describe.skip("tasks", () => {
it("calls the hello service to fetch the usernames populated by the ruby migration", async () => {
/**
* Verify that the output includes the usernames populated by the ruby-migration task.
* The users table was created by the node-migration task.
*/
await runWithEnv(["deploy"])
const logEntries = await runWithEnv(["call", "hello"])
expect(
searchLog(logEntries, /John, Paul, George, Ringo/),
"expected to find populated usernames in log output"
).to.eql("passed")
})
})
}

if (project === "code-synchronization") {
describe("code-synchronization", () => {
it("runs the dev command with code-synchronization enabled", async () => {
Expand Down