chore: 0.13 analytics improvements #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhq
force-pushed
the
0.13-analytics-improvements
branch
3 times, most recently
from
d57d453 to
a082b5c
Compare
mkhq
force-pushed
the
0.13-analytics-improvements
branch
from
a082b5c to
ecf8caf
Compare
mkhq
force-pushed
the
0.13-analytics-improvements
branch
from
4c15109 to
c9d0388
Compare
eysi09
requested changes
May 11, 2023
core/src/analytics/analytics.ts
Outdated
| @@ -92,6 +94,11 @@ interface ProjectMetadata { | |||
| servicesCount: number | |||
| testsCount: number | |||
| moduleTypes: string[] | |||
| actionsCount: number | |||
| actionBuildsCount: number | |||
There was a problem hiding this comment.
Nitpick but feels like this should be called buildActionCount, deployActionCount, etc
core/src/analytics/analytics.ts
Outdated
| @@ -125,6 +132,7 @@ interface CommandEvent extends EventBase { | |||
| type: "Run Command" | |||
| properties: PropertiesBase & { | |||
| name: string | |||
| commandIteration: number | |||
There was a problem hiding this comment.
I think we should skip this for now since we're changing this behaviour in general:
- Introduce the concept of a parent session (with a
parentSessionId) - This would be a persistent session like
garden dev - Every time you run a command within that session, via the terminal / Cloud / Desktop, that gets counted as a single session within the parent session.
- With this, a command can't technically be run twice. Each session is exactly a single command but it can have a parent command. Only persistent commands like
garden devcan be parent commands.
eysi09
previously approved these changes
May 12, 2023
|
@eysi09 I've re-enabled the failing nock tests, if this turns out to be an issue still we can re-add the skip. |
Added the skip back because those tests keep on failing. |
eysi09
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adapt the analytics to 0.13 by including project stats for action kinds.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: