Event bus and websocket endpoint #404
Conversation
|
Could you add instructions for how to interact with the API endpoints? E.g. the shape of the JSON payload, the |
| @@ -22,7 +22,7 @@ import { Module } from "../types/module" | |||
| import { logHeader } from "../logger/util" | |||
|
|
|||
| const buildArguments = { | |||
| module: new StringsParameter({ | |||
| modules: new StringsParameter({ | |||
There was a problem hiding this comment.
Since we're changing this to plural, shouldn't it be updated for all the command arguments? We generally use the singular module and service even though we accept a list of them.
There was a problem hiding this comment.
Sure, we can update the rest of them.
There was a problem hiding this comment.
Added a commit for that.
| const parts = env.split(".") | ||
| const environmentName = parts[0] | ||
| const parts = environmentName.split(".") | ||
| environmentName = parts[0] |
There was a problem hiding this comment.
This is slightly confusing (although not introduced in this PR).
There was a problem hiding this comment.
Yea, I've actually already removed this in another branch.
| * Recursively process all values in the given input, | ||
| * walking through all object keys _and array items_. | ||
| */ | ||
| export function deepMap<T extends object, U extends object = T>( |
There was a problem hiding this comment.
This doesn't appear to be used anywhere.
There was a problem hiding this comment.
True, I copied it in for reference for the deepFilter function, and figured it might as well stay.
The endpoint forwards any event emitted to `garden.events` to open connections, and allows commands to be executed via the socket as well.
garden-service/src/commands/call.ts
Outdated
| @@ -24,7 +24,7 @@ import dedent = require("dedent") | |||
|
|
|||
| const callArgs = { | |||
| serviceAndPath: new StringParameter({ | |||
| help: "The name(s) of the service(s) to call followed by the ingress path (e.g. my-container/somepath).", | |||
| help: "The name(s) of the service to call followed by the ingress path (e.g. my-container/somepath).", | |||
There was a problem hiding this comment.
Why remove the plural (s) from service(s)?
There was a problem hiding this comment.
We can't call more than one service here.
There was a problem hiding this comment.
Ah yes. So name should also be singular then.
There was a problem hiding this comment.
...I'll go ahead and fix it and merge.
This should have no impact on CLI usage.
Added an event bus on
garden.events, and just to kick things off I'm emitting some events from the TaskGraph.The WebSocket endpoint forwards any event emitted to
garden.eventsto openconnections, and allows commands to be executed via the socket as well.