Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch the cleanup command emoji #3992

Merged
merged 1 commit into from
Mar 24, 2023
Merged

chore: switch the cleanup command emoji #3992

merged 1 commit into from
Mar 24, 2023

Conversation

Walther
Copy link
Contributor

@Walther Walther commented Mar 24, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Just a tiny detail I noticed - this got initially done in #3768 and ended up reverted in 61ef901. Do we want to switch again to the recycling symbol, or do we want to keep the revert to skull? This PR can be closed without merging if we prefer to keep the skull in our messaging and style.

@Walther Walther requested review from eysi09 and vvagaytsev March 24, 2023 17:19
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@edvald edvald merged commit 8e858eb into 0.13 Mar 24, 2023
@edvald edvald deleted the 0.13-cleanup-emoji branch March 24, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants