improvement(pulumi): improve preview output #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
force-pushed
the
improved-pulumi-preview-summary
branch
from
7afcf2a to
2a560e4
Compare
thsig
force-pushed
the
improved-pulumi-preview-summary
branch
2 times, most recently
from
baefea6 to
475862e
Compare
We now only show the output of `pulumi preview` when the generated plan is not a no-op. This makes the output much easier to parse visually during a manual review process. We now also copy plans that aren't no-ops to a subdirectory of the preview directory for easier review and deployment.
The script was missing the ARM64 binary from the list.
We now include build tasks in the list of dependencies for plugin tasks for the Pulumi plugin. This ensures that e.g. any required `exec` build steps are run ahead of deployments if needed.
We now generate a total summary of a plan run when running `garden plugins pulumi preview`, which includes preview links, step/operation counts (and more) for each pulumi service affected by the plan. The total summary also includes top-level step counts by operation type (across all affected services). This plan is written to a `plan-summary.json` file inside the `.garden/pulumi.outputs/last-preview` directory. This file is designed to be useful for further automation, e.g. in a CI/CD context.
This fixes an oversight in the logic around Pulumi plugin commands where we forgot to create a new plugin context with a template context specific to the module being processed by Pulumi plugin commands.
Added a `--skip-dependencies` CLI option for all Pulumi plugin commands. This option works similarly as in the `deploy` command.
thsig
force-pushed
the
improved-pulumi-preview-summary
branch
from
475862e to
7ca5f52
Compare
vvagaytsev
reviewed
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We now only show the output of
pulumi previewwhen the generated plan is not a no-op. This makes the output much easier to parse visually during a manual review process.We now also copy plans that aren't no-ops to a subdirectory of the preview directory for easier review and deployment, and write a total summary of the generated plans (including preview links and operation counts by affected service, and total counts).
The latter is designed to be useful for further automation, e.g. in a CI/CD context.