Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incompatible with git 2.36.0 #2940

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

vvagaytsev
Copy link
Collaborator

What this PR does / why we need it:
This PR fixes compatibility issues with Git 2.36.0, which has stricter repository ownership checks.

Which issue(s) this PR fixes:

Fixes #2905

Special notes for your reviewer:

@vvagaytsev vvagaytsev force-pushed the fix/incompatible-with-git-2.36.0 branch 9 times, most recently from 439490a to 4402f36 Compare May 9, 2022 13:51
@vvagaytsev vvagaytsev marked this pull request as ready for review May 9, 2022 13:52
@vvagaytsev vvagaytsev requested a review from edvald May 9, 2022 13:53
core/src/vcs/git.ts Outdated Show resolved Hide resolved
@vvagaytsev vvagaytsev force-pushed the fix/incompatible-with-git-2.36.0 branch from daf3252 to 8a33e1b Compare May 9, 2022 14:33
@vvagaytsev vvagaytsev requested a review from Orzelius May 10, 2022 12:22
Orzelius
Orzelius previously approved these changes May 10, 2022
Copy link
Contributor

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpic but otherwise great 👍

core/src/vcs/git.ts Outdated Show resolved Hide resolved
@vvagaytsev vvagaytsev force-pushed the fix/incompatible-with-git-2.36.0 branch from 8a33e1b to 3ed1890 Compare May 10, 2022 13:09
@vvagaytsev vvagaytsev requested a review from Orzelius May 10, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with git 2.36.0
3 participants