fix: incl. ingresses & services in delete command. #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting a container service via the delete command, also delete its k8s service and ingress. This fixes problems previously caused by dangling k8s ingresses/services.
edvald
requested changes
Sep 19, 2018
| @@ -193,3 +198,28 @@ export async function applyMany( | |||
| return result.output | |||
| } | |||
| } | |||
|
|
|||
| const defaultObjectTypesForDelete = ["deployment", "service", "ingress"] | |||
There was a problem hiding this comment.
I think it makes sense to simply make this a required parameter and not have defaults.
| }) { | ||
| const api = new KubeApi(provider) | ||
| export async function deleteContainerService( | ||
| { namespace, provider, serviceName, deploymentOnly, logEntry }, |
There was a problem hiding this comment.
Instead of this flag, I'd just implement this logic specifically in the OpenFaaS handler. And actually I'd suggest using the faas-cli command there instead (and perhaps make a quick helper for it, because of all that docker run stuff we do there now).
|
|
||
| export async function deleteObjectsByLabel( | ||
| context: string, namespace: string, labelKey: string, labelValue: string, | ||
| { includeUninitialized = false, objectTypes = defaultObjectTypesForDelete }: DeleteOptions = {}, |
There was a problem hiding this comment.
Because we have so many parameters here now, I'd suggest putting all of them in an object. Too many positionals are just confusing to write.
edvald
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a container service via the delete command, also delete
its k8s service and ingress.
This fixes problems previously caused by dangling k8s
ingresses/services.