Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link specifically to edge version #284

Merged
merged 1 commit into from
Sep 20, 2018
Merged

docs: link specifically to edge version #284

merged 1 commit into from
Sep 20, 2018

Conversation

vkorbes
Copy link
Contributor

@vkorbes vkorbes commented Sep 18, 2018

I always find it a bit of a hassle to find the specific link to the Edge version of Docker, so I thought I'd use it in the documentation instead of the generic Docker For Windows one.

@drubin
Copy link
Contributor

drubin commented Sep 18, 2018

@ellenkorbes Minor issue, your commit should be docs: since the changelog is auto-generated from this.

ref https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#type

@vkorbes vkorbes changed the title fix: link specifically to edge version docs: link specifically to edge version Sep 18, 2018
@vkorbes
Copy link
Contributor Author

vkorbes commented Sep 18, 2018

Fixed. Thanks @drubin.

@drubin
Copy link
Contributor

drubin commented Sep 18, 2018

@ellenkorbes Maybe we need to make it more clear you need the edge version only the URL contains edge and I not sure people will notice their versions are different from edge?

@vkorbes
Copy link
Contributor Author

vkorbes commented Sep 18, 2018

The text immediately preceding this link is

Docker - We strongly recommend using the Edge version

so IMO we're fine in that regard.

@edvald edvald merged commit 20da5cb into master Sep 20, 2018
@edvald edvald deleted the windows branch September 20, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants