-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutagen (dev mode) improvements #2491
Conversation
902e60c
to
4d1321b
Compare
Good stuff! One thing I noticed: If I run
|
Ah, seems the mode flag is not set right. Will fix. |
4d1321b
to
3d320e7
Compare
Another thing I noticed: The Joi validation of I was able to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only had one (minor) additional comment there.
0ef23be
to
c9dd1a5
Compare
c9dd1a5
to
0612f32
Compare
@thsig did you test this manually? Would you mind kicking it around a bit with |
8d18080
to
fc066c0
Compare
We now poll for more information from the mutagen daemon, and we've overall improved the process management around it. This unblocks more development around this feature, such as running a postSyncCommand (like with the old hot reloading mechanism) and also makes the use of mutagen easier for other contexts like syncing build contexts for in-cluster building.
Also updated our docs a bit. Closes #2519
You can now set `GARDEN_K8S_BUILD_SYNC_MODE=mutagen` to enable a new, as yet experimental build sync mode, which replaces rsync with mutagen for synchronizing build contexts ahead of `kaniko` and `cluster-buildkit` builds. Please give it a spin, since we want to battle-test this a bit before removing the older rsync method.
Just to make it a bit more clear which tests are to run in which context.
fc066c0
to
41ad3e0
Compare
41ad3e0
to
297d8c4
Compare
Yeah, I've poked at this from many different directions—looks good so far 👍 |
Combining a few related commits, around the mutagen sync mechanism:
improvement(k8s): better process mgmt and logging for dev mode sync
We now poll for more information from the mutagen daemon, and we've overall improved the process management around it.
Besides the improved runtime information, this unblocks more development around this feature, such as running a postSyncCommand (like with the old hot reloading mechanism) and also makes the use of mutagen easier for other contexts like syncing build contexts for in-cluster building.
Also closes #2519 through a few added option flags.
feat(k8s): allow owner/perm tweaks on dev mode syncs
Also updated our docs a bit.
Closes #2519
feat(k8s): add experimental mutagen-based build sync mode
You can now set
GARDEN_K8S_BUILD_SYNC_MODE=mutagen
to enable a new,as yet experimental build sync mode, which replaces rsync with mutagen
for synchronizing build contexts ahead of
kaniko
andcluster-buildkit
builds.Please give it a spin, since we want to battle-test this a bit before
removing the older rsync method.