Multi-repo: ensure external source gets updated if repo url changes #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
multi-repos-hash-dirname
branch
from
09230f0 to
bec01c0
Compare
eysi09
changed the title
edvald
reviewed
Aug 24, 2018
garden-cli/src/vcs/git.ts
Outdated
| } | ||
| }, | ||
| } | ||
|
|
||
| function getUrlHash(url: string) { | ||
| return (parse(url).hash || "").split("#")[1] | ||
| function getGitUrlParts(url: string): { repositoryUrl: string, hash: string } { |
There was a problem hiding this comment.
Doesn't really matter here, but this type annotation can also just be inferred and not explicitly stated.
edvald
reviewed
Aug 24, 2018
garden-cli/src/vcs/git.ts
Outdated
| if (!isCloned) { | ||
| const entry = logEntry.info({ section: name, msg: `Fetching from ${url}`, entryStyle: EntryStyle.activity }) | ||
| const { repositoryUrl, hash } = getGitUrlParts(url) | ||
| await git("clone", "--depth", "1", "--branch", hash, repositoryUrl, absPath) |
There was a problem hiding this comment.
What if the hash is an empty string here?
edvald
reviewed
Aug 24, 2018
garden-cli/src/vcs/git.ts
Outdated
| await git("remote", "update") | ||
|
|
||
| const remoteHash = (await git("ls-remote", repositoryUrl, hash)).split("\t")[0] | ||
| const localHash = (await git("show-ref", "--hash", hash)).split("\n")[0] |
There was a problem hiding this comment.
Same question here. Do we need to have a default hash/branch? Or would it make more sense to conditionally add these params?
eysi09
force-pushed
the
multi-repos-hash-dirname
branch
from
bec01c0 to
323b6e9
Compare
|
I've resolved the issues above. |
edvald
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.