Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4.0 #236

Merged
merged 4 commits into from
Aug 17, 2018
Merged

Release 0.4.0 #236

merged 4 commits into from
Aug 17, 2018

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Aug 17, 2018

No description provided.

@edvald edvald force-pushed the release-0.4.0 branch 3 times, most recently from 0b8259a to 4442df9 Compare August 17, 2018 16:58
Copy link
Collaborator

@thsig thsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to fix a couple of typos.


* **config:** Module name no longer defaults to directory name but must be explicitly
set in the module's garden.yml file. Any existing garden.yml module files
without a name key must therefore be updated to expclitily provide the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ expclitily_ -> explicitly


* **config:** Module name no longer defaults to directory name but must be explicitly
set in the module's garden.yml file. Any existing garden.yml module files
without a name key must therefore be updated to expclitily provide the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expclitily -> explicitly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are auto-generated from commit messages. I don't think we should rewrite the changelog.

@thsig thsig merged commit e72d5d0 into master Aug 17, 2018
@edvald edvald deleted the release-0.4.0 branch August 17, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants