fix(core): default back to rsync build staging on Windows #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This temporarily mitigates #2299 by reverting back to using rsync for build staging on Windows, while we work out why exactly it fails for some users/projects. Users can still opt into the newer rsync-less mode by setting `GARDEN_EXPERIMENTAL_BUILD_STAGE=true` in their shell environment.
thsig
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This temporarily mitigates #2299 by reverting back to using rsync for
build staging on Windows, while we work out why exactly it fails for
some users/projects.
Users can still opt into the newer rsync-less mode by setting
GARDEN_EXPERIMENTAL_BUILD_STAGE=truein their shell environment.