improvement: explicitly catch EMFILE errors with better error message #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
reviewed
Sep 3, 2020
core/src/util/util.ts
Outdated
| @@ -142,7 +142,7 @@ export function makeErrorMsg({ | |||
|
|
|||
| ${trimEnd(error, "\n")} | |||
| ` | |||
| if (output !== error) { | |||
| if (out && output !== error) { | |||
There was a problem hiding this comment.
Shouldn't this be if output && ... since out is just output that's been formatted.
Another one in the series of potential errors when the project file count is too high. See issue #2003 for one reported case of this.
eysi09
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one in the series of potential errors when the project file
count is too high.
See issue #2003 for one reported case of this.