Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): add skip option for workflow steps #1985

Merged
merged 1 commit into from
Aug 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions docs/reference/commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -1223,12 +1223,18 @@ workflowConfigs:
# A description of the workflow step.
description:

# A bash script to run. Note that the host running the workflow must have bash installed and on path. It is
# considered to have run successfully if it returns an exit code of 0. Any other exit code signals an error,
# A bash script to run. Note that the host running the workflow must have bash installed and on path.
# It is considered to have run successfully if it returns an exit code of 0. Any other exit code signals an
# error,
# and the remainder of the workflow is aborted.
#
# The script may include template strings, including references to previous steps.
script:

# Set to true to skip this step. Use this with template conditionals to skip steps for certain environments or
# scenarios.
skip:

# A list of triggers that determine when the workflow should be run, and which environment should be used (Garden
# Enterprise only).
triggers:
Expand Down
33 changes: 29 additions & 4 deletions docs/reference/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -970,12 +970,17 @@ steps:
# A description of the workflow step.
description:

# A bash script to run. Note that the host running the workflow must have bash installed and on path. It is
# considered to have run successfully if it returns an exit code of 0. Any other exit code signals an error, and
# the remainder of the workflow is aborted.
# A bash script to run. Note that the host running the workflow must have bash installed and on path.
# It is considered to have run successfully if it returns an exit code of 0. Any other exit code signals an error,
# and the remainder of the workflow is aborted.
#
# The script may include template strings, including references to previous steps.
script:

# Set to true to skip this step. Use this with template conditionals to skip steps for certain environments or
# scenarios.
skip: false

# A list of triggers that determine when the workflow should be run, and which environment should be used (Garden
# Enterprise only).
triggers:
Expand Down Expand Up @@ -1218,13 +1223,33 @@ A description of the workflow step.

[steps](#steps) > script

A bash script to run. Note that the host running the workflow must have bash installed and on path. It is considered to have run successfully if it returns an exit code of 0. Any other exit code signals an error, and the remainder of the workflow is aborted.
A bash script to run. Note that the host running the workflow must have bash installed and on path.
It is considered to have run successfully if it returns an exit code of 0. Any other exit code signals an error,
and the remainder of the workflow is aborted.

The script may include template strings, including references to previous steps.

| Type | Required |
| -------- | -------- |
| `string` | No |

### `steps[].skip`

[steps](#steps) > skip

Set to true to skip this step. Use this with template conditionals to skip steps for certain environments or scenarios.

| Type | Default | Required |
| --------- | ------- | -------- |
| `boolean` | `false` | No |

Example:

```yaml
steps:
- skip: "${environment.name != 'prod'}"
```

### `triggers[]`

A list of triggers that determine when the workflow should be run, and which environment should be used (Garden Enterprise only).
Expand Down
11 changes: 11 additions & 0 deletions garden-service/src/commands/run/workflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,17 @@ export class RunWorkflowCommand extends Command<Args, {}> {
const stepBodyLog = outerLog.placeholder({ indent: 1, metadata })
const stepFooterLog = outerLog.placeholder({ indent: 1, metadata })
garden.log.setState({ metadata })

if (step.skip) {
stepBodyLog.setState(chalk.yellow(`Skipping`))
result.steps[stepName] = {
number: index + 1,
outputs: {},
log: "",
}
continue
}

let stepResult: CommandResult
const inheritedOpts = cloneDeep(opts)

Expand Down
10 changes: 9 additions & 1 deletion garden-service/src/config/workflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export interface WorkflowStepSpec {
command?: string[]
description?: string
script?: string
skip?: boolean
}

export const workflowStepSchema = () => {
Expand Down Expand Up @@ -175,14 +176,21 @@ export const workflowStepSchema = () => {
.example(["run", "task", "my-task"]),
description: joi.string().description("A description of the workflow step."),
script: joi.string().description(
deline`
dedent`
A bash script to run. Note that the host running the workflow must have bash installed and on path.
It is considered to have run successfully if it returns an exit code of 0. Any other exit code signals an error,
and the remainder of the workflow is aborted.

The script may include template strings, including references to previous steps.
`
),
skip: joi
.boolean()
.default(false)
.description(
`Set to true to skip this step. Use this with template conditionals to skip steps for certain environments or scenarios.`
)
.example("${environment.name != 'prod'}"),
})
.xor("command", "script")
.description("A workflow step. Must specify either `command` or `script` (but not both).")
Expand Down
22 changes: 22 additions & 0 deletions garden-service/test/unit/src/commands/run/workflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,28 @@ describe("RunWorkflowCommand", () => {
expect(result?.steps["step-1"].log).to.equal(garden.projectRoot)
})

it("should skip disabled steps", async () => {
garden.setWorkflowConfigs([
{
apiVersion: DEFAULT_API_VERSION,
name: "workflow-a",
kind: "Workflow",
path: garden.projectRoot,
files: [],
steps: [{ script: "pwd" }, { script: "echo fail!; exit 1", skip: true }],
},
])

await cmd.action({ ...defaultParams, args: { workflow: "workflow-a" } })

const { result, errors } = await cmd.action({ ...defaultParams, args: { workflow: "workflow-a" } })

expect(result).to.exist
expect(errors).to.not.exist
expect(result?.steps["step-2"].outputs).to.eql({})
expect(result?.steps["step-2"].log).to.equal("")
})

it("should collect log outputs, including stderr, from a script step", async () => {
garden.setWorkflowConfigs([
{
Expand Down
19 changes: 16 additions & 3 deletions garden-service/test/unit/src/config/workflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ describe("resolveWorkflowConfig", () => {
name: "workflow-a",
path: "/tmp/foo",
description: "Sample workflow",
steps: [{ description: "Deploy the stack", command: ["deploy"] }, { command: ["test"] }],
steps: [
{ description: "Deploy the stack", command: ["deploy"], skip: false },
{ command: ["test"], skip: false },
],
triggers: [
{
environment: "local",
Expand All @@ -68,7 +71,10 @@ describe("resolveWorkflowConfig", () => {
name: "workflow-a",
path: "/tmp/foo",
description: "Secret: ${secrets.foo}, var: ${variables.foo}",
steps: [{ description: "Deploy the stack", command: ["deploy"] }, { command: ["test"] }],
steps: [
{ description: "Deploy the stack", command: ["deploy"], skip: false },
{ command: ["test"], skip: false },
],
}

expect(resolveWorkflowConfig(garden, config)).to.eql({
Expand All @@ -87,7 +93,14 @@ describe("resolveWorkflowConfig", () => {
steps: [{ description: "Deploy the stack", command: ["deploy"] }, { command: ["test"] }],
}

expect(resolveWorkflowConfig(garden, config)).to.eql({ ...config, ...defaults })
expect(resolveWorkflowConfig(garden, config)).to.eql({
...config,
...defaults,
steps: [
{ description: "Deploy the stack", command: ["deploy"], skip: false },
{ command: ["test"], skip: false },
],
})
})

it("should throw if a step uses an invalid/unsupported command", async () => {
Expand Down