Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy util service if using kaniko #1963

Merged
merged 2 commits into from
Jul 29, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions garden-service/src/plugins/kubernetes/kubernetes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ export async function configureProvider({
if (config.buildMode === "cluster-docker" || config.buildMode === "kaniko") {
config._systemServices.push("build-sync")

if (!config.deploymentRegistry || config.deploymentRegistry.hostname === inClusterRegistryHostname) {
const usingInClusterRegistry =
!config.deploymentRegistry || config.deploymentRegistry.hostname === inClusterRegistryHostname

if (usingInClusterRegistry) {
// Deploy an in-cluster registry, unless otherwise specified.
// This is a special configuration, used in combination with the registry-proxy service,
// to make sure every node in the cluster can resolve the image from the registry we deploy in-cluster.
Expand All @@ -75,7 +78,10 @@ export async function configureProvider({
namespace: config.deploymentRegistry?.namespace || projectName,
}
config._systemServices.push("docker-registry", "registry-proxy")
} else {
}
if (!usingInClusterRegistry || config.buildMode === "kaniko") {
// If using an external registry we need the util service
// Also the kaniko buildMode needs the util service even if using an in-cluster registry
config._systemServices.push("util")
}

Expand Down