fix(k8s): ensure rendered helm chart contain runtime values [WIP] #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
fix-helm-render
branch
2 times, most recently
from
2737f30 to
e30c9a9
Compare
|
Not quite sure why this is failing, and especially why it's not failing consistently. |
eysi09
changed the title
The `helm template` command doesn't render values that need to be retrieved from the cluster. We therefore use `helm install|upgrade --dry-run` instead.
|
@eysi09 it does appear to be failing consistently, on the same test. Perhaps something to do with how the output from the |
|
This is after making some changes that broke all the things. Before, it only failed for K8s version 1.15 and up (IIRC). And yes, it did fail consistently for those. (In case you were looking at the CI results after making the change). |
|
Closing in favor of a slightly different approach (I'll build off this branch but make some further changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
helm templatecommand doesn't render values that need to beretrieved from the cluster. We therefore use
helm install|upgrade --dry-runinstead.Which issue(s) this PR fixes:
Fixes #1795
Special notes for your reviewer:
N/A