Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct spelling of against #1747

Merged
merged 4 commits into from
Apr 7, 2020
Merged

docs: correct spelling of against #1747

merged 4 commits into from
Apr 7, 2020

Conversation

jeremiahpslewis
Copy link
Contributor

What this PR does / why we need it: Fixes code comment typo

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

edvald
edvald requested changes Mar 28, 2020
View reviewed changes
Copy link
Collaborator

@edvald edvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlewis91! There's a formatting error that prettier is complaining about (probably something your IDE is doing automatically), just needs to be reverted, and then we'll merge.

garden-service/src/config/project.ts Outdated
@@ -285,7 +285,7 @@ export const projectDocsSchema = () =>
.description((<any>environmentsSchema().describe().flags).description),
providers: joiArray(providerConfigBaseSchema()).description(
"A list of providers that should be used for this project, and their configuration. " +
"Please refer to individual plugins/providers for details on how to configure them."
"Please refer to individual plugins/providers for details on how to configure them."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prettier linter is complaining about this

@jeremiahpslewis
Copy link
Contributor Author

@edvald fixed. :)

@eysi09
Copy link
Collaborator

eysi09 commented Apr 1, 2020

Looks like the check-docs script is failing. You need to run npm run generate-docs from the root to fix this and commit the changes.

Note that you need to have parallel installed to run the script. You can install with most package managers, for example on macOS you can do brew install parallel.

@jeremiahpslewis
Copy link
Contributor Author

@eysi09 Thanks for the pointers. Checks pass now.

@eysi09 eysi09 merged commit 59f46bb into garden-io:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvald edvald edvald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiahpslewis @eysi09 @edvald