fix(cli): enforce single character option aliases #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
single-char-aliases
branch
from
acb4fa0 to
185896d
Compare
edvald
reviewed
Jun 6, 2018
src/cli/cli.ts
Outdated
| return cli.parse().then(result => shutdown(result.code)) | ||
| try { | ||
| const cli = new GardenCli() | ||
| return cli.parse().then(result => shutdown(result.code)) |
There was a problem hiding this comment.
I think it'd make sense to change this line along the way to
const result = await cli.parse()
shutdown(result.code)
There was a problem hiding this comment.
Good catch! I threw in a finally statement there as well.
eysi09
force-pushed
the
single-char-aliases
branch
from
185896d to
a49e799
Compare
edvald
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151