Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add protection to more commands #1378

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Dec 4, 2019

Set protected = true on delete commands.

@edvald
Copy link
Collaborator

edvald commented Dec 4, 2019

Could we add tests for this on individual commands? Or at least assertions that the flag is set on them. I'd hate for us to accidentally remove the protection in some refactor.

@baspetersdotjpeg
Copy link
Contributor

Fixes the issue 👍

@eysi09 eysi09 changed the title improvement: add protection to more commands improvement: add protection to more commands [WIP] Dec 5, 2019
@eysi09 eysi09 force-pushed the delete-protection branch from 3151abd to c9cb5e6 Compare December 5, 2019 13:04
@eysi09 eysi09 changed the title improvement: add protection to more commands [WIP] improvement: add protection to more commands Dec 5, 2019
@eysi09 eysi09 force-pushed the delete-protection branch from c9cb5e6 to df76dc3 Compare December 5, 2019 13:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@eysi09 eysi09 merged commit a44ebf1 into master Dec 5, 2019
@eysi09 eysi09 deleted the delete-protection branch December 5, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants