Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restructure and add new basic guides #1300

Merged
merged 2 commits into from
Nov 6, 2019
Merged

docs: restructure and add new basic guides #1300

merged 2 commits into from
Nov 6, 2019

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Nov 1, 2019

This PR re-names the Using Garden section of our docs to Guides and adds a new Using Garden section. The new section contains a guide for each of the main Garden primitives: project, module, service, test, and task.

The idea was for each of these guides to be short, to the point, and independent of other context. So you can go through these one by one as you're adding these primitives to your project. You can also imagine a user who already has a project with modules and services and now wants to start using Garden to run their tests. They should then be able to go straight to Using Garden > Running Tests and find everything they need to get started.

This is still a work in progress but open for review.

One thing I've found challenging is balancing the abstract and the concrete. For example writing about services as an abstract Garden primitive, and at they same time give concrete and useful examples which are of course specific to different plugins.

So I'm assuming we'll have to do some iterations on this. All comments, suggestions, nitpicks, etc are therefore very much appreciated.

@eysi09 eysi09 marked this pull request as ready for review November 1, 2019 21:21
docs/using-garden/README.md Outdated Show resolved Hide resolved
docs/using-garden/adding-modules.md Outdated Show resolved Hide resolved
docs/using-garden/adding-modules.md Outdated Show resolved Hide resolved
docs/using-garden/adding-modules.md Show resolved Hide resolved
docs/using-garden/adding-modules.md Show resolved Hide resolved
docs/using-garden/running-tests.md Outdated Show resolved Hide resolved
docs/using-garden/running-tests.md Outdated Show resolved Hide resolved
docs/using-garden/running-tests.md Outdated Show resolved Hide resolved
docs/using-garden/running-tests.md Outdated Show resolved Hide resolved
docs/using-garden/running-tests.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@edvald edvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the structure, just needs some polish. Added a bunch of small comments.

@eysi09
Copy link
Collaborator Author

eysi09 commented Nov 6, 2019

Addressed the PR comments in a separate commit.

@eysi09 eysi09 changed the title docs: restructure and add new basic guides (wip) docs: restructure and add new basic guides Nov 6, 2019
docs/using-garden/README.md Outdated Show resolved Hide resolved
docs/using-garden/adding-services.md Outdated Show resolved Hide resolved
@@ -102,8 +100,14 @@ services:

### Kubernetes Providers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title seems a little odd. Maybe just skip it?

docs/using-garden/creating-a-project.md Outdated Show resolved Hide resolved
docs/using-garden/running-tasks.md Outdated Show resolved Hide resolved
Note: This will fail in CI since the links we're updating haven't breen
created yet on docs.garden.io. They will be created automatically though
on merge to master, so we can safely ignore the CI check.
@eysi09 eysi09 merged commit 30449d8 into master Nov 6, 2019
@eysi09 eysi09 deleted the docs-restructure branch November 6, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants