-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: restructure and add new basic guides #1300
Conversation
22e9757
to
cb80270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the structure, just needs some polish. Added a bunch of small comments.
cb80270
to
6fe66f5
Compare
Addressed the PR comments in a separate commit. |
6fe66f5
to
802b05b
Compare
docs/using-garden/adding-services.md
Outdated
@@ -102,8 +100,14 @@ services: | |||
|
|||
### Kubernetes Providers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title seems a little odd. Maybe just skip it?
Note: This will fail in CI since the links we're updating haven't breen created yet on docs.garden.io. They will be created automatically though on merge to master, so we can safely ignore the CI check.
4e2ee0c
to
644ab65
Compare
This PR re-names the Using Garden section of our docs to Guides and adds a new Using Garden section. The new section contains a guide for each of the main Garden primitives: project, module, service, test, and task.
The idea was for each of these guides to be short, to the point, and independent of other context. So you can go through these one by one as you're adding these primitives to your project. You can also imagine a user who already has a project with modules and services and now wants to start using Garden to run their tests. They should then be able to go straight to Using Garden > Running Tests and find everything they need to get started.
This is still a work in progress but open for review.
One thing I've found challenging is balancing the abstract and the concrete. For example writing about services as an abstract Garden primitive, and at they same time give concrete and useful examples which are of course specific to different plugins.
So I'm assuming we'll have to do some iterations on this. All comments, suggestions, nitpicks, etc are therefore very much appreciated.