chore(tests): create separate integ test suite #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
integ-suite
branch
2 times, most recently
from
d8c1624 to
9f903c3
Compare
10ko
approved these changes
Nov 6, 2019
|
Once the conflicts are fixed, I'll merge. |
|
I figured 30 seconds would be plenty, haven't seen any tests take longer. |
|
I stand corrected, I must have had some bad run at some point. I checked some recent run and it looks the max is 17-18 seconds. |
Also did some minor refactoring on the e2e tests, and updated the contributor docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Split some of our tests into a separate
integsuite. We should use this for tests that require e.g. Docker, Kubernetes or other runtime dependencies to be running on the machine when executing.These tests currently run in the
test-minikubejob in CI.Also did some minor refactoring on the e2e tests, and updated the
contributor docs.