fix(vcs): no files were found when dotIgnoreFiles was set to empty list #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
reviewed
Oct 11, 2019
| @@ -166,16 +166,20 @@ export class GitHandler extends VcsHandler { | |||
| // We push to the output array when all ls-files commands "agree" that it should be included, | |||
| // and it passes through the include/exclude filters. | |||
| if ( | |||
| paths[resolvedPath] === this.ignoreFiles.length | |||
| paths[resolvedPath] >= this.ignoreFiles.length | |||
There was a problem hiding this comment.
Otherwise the fix doesn't work when there are no ignore files, since the count (1) is higher than the number of ignore files (0).
eysi09
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If you set
dotIgnoreFiles: []in your project config, no modules would be found.Which issue(s) this PR fixes:
Just came across this myself.