Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: added more headers to checkForUpdates #1170

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

10ko
Copy link
Member

@10ko 10ko commented Sep 9, 2019

What this PR does / why we need it:
This adds some extra headers to the checkForUpdate request and allows us to be able to filter better the requests on the backend side.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@10ko 10ko requested review from edvald and eysi09 September 9, 2019 22:08
Copy link
Collaborator

@edvald edvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we forgot about the CI flag. Could we throw that in there?

@10ko 10ko force-pushed the enhancement-get-version branch from c7e0afb to 2e47466 Compare September 11, 2019 09:51
@10ko 10ko force-pushed the enhancement-get-version branch from 2e47466 to 1ee8884 Compare September 11, 2019 10:03
@10ko 10ko force-pushed the enhancement-get-version branch from 4b717a6 to 8f1c443 Compare September 11, 2019 10:34
@thsig thsig merged commit 502ae97 into master Sep 11, 2019
@thsig thsig deleted the enhancement-get-version branch September 11, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants