Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: also remove 'edge' tag when stripping tags #1030

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Jul 25, 2019

No description provided.

@edvald
Copy link
Collaborator

edvald commented Jul 25, 2019

Can you give some context for this? Just curious

@eysi09
Copy link
Collaborator Author

eysi09 commented Jul 26, 2019

Yup, it's for generating a clean changelog. The changelog is basically based on the tags so having the edge tag in there will add an entry for that in the changelog.

The flow looks like this:

  1. Pull all remote tags
  2. Delete all pre-release tags locally so that we only have tags like: v0.1.1, v0.2.0, .., v0.10.2.
  3. Also delete the edge tag
  4. Generate the changelog
  5. Pull all remote tags to reset the original state

@eysi09
Copy link
Collaborator Author

eysi09 commented Jul 26, 2019

Actually, this might not be needed if I tweak the command that generates the changelog. I'll close this for now.

@eysi09 eysi09 closed this Jul 26, 2019
@eysi09 eysi09 reopened this Jul 26, 2019
@eysi09
Copy link
Collaborator Author

eysi09 commented Jul 26, 2019

Scratch that, we do need this.

@edvald edvald merged commit a1dfaba into master Jul 29, 2019
@edvald edvald deleted the release-script-remove-edge-tag branch July 29, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants