Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of plugin modules is always "0000000000" #84

Closed
edvald opened this issue Apr 25, 2018 · 0 comments · Fixed by #92
Closed

Version of plugin modules is always "0000000000" #84

edvald opened this issue Apr 25, 2018 · 0 comments · Fixed by #92
Assignees
Labels

Comments

@edvald
Copy link
Collaborator

edvald commented Apr 25, 2018

This is because we make the assumption in our current Module.getVersion() code that modules are in a project git tree. We need to add more ways to specify versions and/or automatically retrieve the version of the plugin and use that instead. Or I suppose we could hash the contents of the plugin directory, but that feels like it would be flimsy. Ideas welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant