fix(k8s): correctly set image pull secret on sync pod #6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
fix-sync-util-secrets-spec
branch
from
ba9d3d6 to
678ea4a
Compare
auto-merge was automatically disabled
October 13, 2024 10:51
Pull request was converted to draft
eysi09
changed the title
|
Oh, good catch 👍 I oversaw that. |
|
Just adding some tests before I flag as ready for review |
eysi09
force-pushed
the
fix-sync-util-secrets-spec
branch
from
678ea4a to
26481cf
Compare
Before this fix, we'd add image pull secrets with name and namespace to the Pod spec but the namespace field isn't allowed so applying the manifest fails. Now we only add the name. Also added test for the 'configureSyncMode' function. The compiler didn't catch this because it allows excess properties (except for object literals).
eysi09
force-pushed
the
fix-sync-util-secrets-spec
branch
from
26481cf to
a89f2e0
Compare
|
FYI: Added tests and also re-enabled the tests that were being skipped. Not quite sure what the original issue was but I refactored the code a bit and now they seem to pass. |
eysi09
changed the title
twelvemo
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, we'd add image pull secrets with name and namespace to the Pod spec but the namespace field isn't allowed so applying the manifest fails. Now we only add the name.
This isn't caught by the TS compiler because it doesn't check for excess properties (except when using object literals).
That is:
TODO: