fix(k8s): correctly set image pull secret on sync pod

Before this fix, we'd add image pull secrets with name and namespace to
the Pod spec but the namespace field isn't allowed so applying the
manifest fails.

Now we only add the name. Also added test for the 'configureSyncMode'
function.

The compiler didn't catch this because it allows excess properties
(except for object literals).

core/src/plugins/kubernetes/container/deployment.ts

@@ -237,6 +237,7 @@ export async function createWorkloadManifest({
   production,
 }: CreateDeploymentParams): Promise<KubernetesWorkload> {
   const spec = action.getSpec()
+
   const mode = action.mode()
 
   let configuredReplicas = spec.replicas || DEFAULT_MINIMUM_REPLICAS

core/src/plugins/kubernetes/kubernetes-type/handlers.ts

@@ -598,7 +598,7 @@ async function configureSpecialModesForManifests({
       log,
     })
   } else if (mode === "sync" && spec.sync && !isEmpty(spec.sync)) {
-    // The "sync-mode" annotation is set in `configureDevMode`.
+    // The "sync-mode" annotation is already set.
     return configureSyncMode({
       ctx,
       log,

core/src/plugins/kubernetes/sync.ts

@@ -303,7 +303,7 @@ export async function configureSyncMode({
   spec,
 }: {
   ctx: PluginContext
-  log: Log
+  log: ActionLog
   provider: KubernetesProvider
   action: Resolved<SyncableRuntimeAction>
   defaultTarget: KubernetesTargetResourceSpec | undefined
@@ -461,10 +461,12 @@ export async function configureSyncMode({
     if (!podSpec.initContainers) {
       podSpec.initContainers = []
     }
+
     if (!podSpec.imagePullSecrets) {
       podSpec.imagePullSecrets = []
     }
     const k8sSyncUtilImageName = getK8sSyncUtilImageName()
+
     if (!podSpec.initContainers.find((c) => c.image === k8sSyncUtilImageName)) {
       const initContainer: V1Container = {
         name: k8sSyncUtilContainerName,
@@ -479,7 +481,8 @@ export async function configureSyncMode({
         volumeMounts: [gardenVolumeMount],
       }
       podSpec.initContainers.push(initContainer)
-      podSpec.imagePullSecrets.push(...provider.config.imagePullSecrets)
+
+      podSpec.imagePullSecrets.push(...provider.config.imagePullSecrets.map((s) => ({ name: s.name })))
     }
 
     if (!targetContainer.volumeMounts) {