fix(template): avoid premature disabled flag evaluation on actions
#6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/template-strings-in-disabled-flag-new
branch
from
3d90797 to
f279492
Compare
vvagaytsev
changed the title
disabled flag evaluation on actions
vvagaytsev
force-pushed
the
fix/template-strings-in-disabled-flag-new
branch
from
f279492 to
9a1023e
Compare
vvagaytsev
force-pushed
the
fix/template-strings-in-disabled-flag-new
branch
from
b3c47dc to
fb6a6a1
Compare
stefreak
previously approved these changes
Sep 17, 2024
core/test/data/test-projects/disabled-action-with-var-context/runs.garden.yml
Show resolved
Hide resolved
vvagaytsev
force-pushed
the
fix/template-strings-in-disabled-flag-new
branch
from
fb6a6a1 to
db08407
Compare
stefreak
reviewed
Sep 17, 2024
* Do early `disabled` flag evaluation only for actions with duplicate names. * Deny the usage of `var` and `variables` contexts in early `disabled` flag evaluation. The contexts `var` and `variables` contexts are not fully resolved at that stage. That can lead to incorrectly resolved `disabled` flag values. Co-authored-by: Steffen Neubauer <[email protected]>
It can never be `WorkflowConfig`.
Co-authored-by: Steffen Neubauer <[email protected]>
vvagaytsev
force-pushed
the
fix/template-strings-in-disabled-flag-new
branch
from
9001fcf to
154c967
Compare
stefreak
reviewed
Sep 17, 2024
stefreak
reviewed
Sep 17, 2024
| name: run-script | ||
| type: exec | ||
| var: | ||
| $merge: ${actions.run["run-script"].var} |
There was a problem hiding this comment.
What happens if I use actions context directly in the disabled flag? Should we deny that as well?
There was a problem hiding this comment.
It's already denied, the error will be thrown:
Invalid template string (...) at path disabled: Could not find key actions. Available keys: command, datetime, environment, git, inputs, local, parent, project, secrets, template, this, var and variables.
Co-authored-by: Steffen Neubauer <[email protected]>
stefreak
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
disabledflag evaluation only for actions with duplicate names.varandvariablescontexts in earlydisabledflag evaluation.The contexts
varandvariablescontexts are not fully resolved at that stage.That can lead to incorrectly resolved
disabledflag values.Which issue(s) this PR fixes:
Patches #4805, #5686, #6293, and #6406.
Special notes for your reviewer: