fix: retain original process env when call spawn
helper
#6301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Prior to #6294 we have never used the
env
parameter of the functioncontainerHelpers.dockerCli(...)
.This PR ensures that the original process environment is always preserved and pass to the Docker process.
Without this fix, any custom
env
would replace the original process environment variables.Instead of composing the merged env vars on the caller side, it's now done inside the helper function.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: