Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pulumi): respect --skip-dependencies flag in preview command #6226

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

vvagaytsev
Copy link
Collaborator

What this PR does / why we need it:

The flag --skip-dependencies was initially implemented in #3096.

The logic that respects the flag was removed in e54d1b5, likely by accident.
This commit restores the logic that prevents dependency resolution if the corresponding flag is set.

Which issue(s) this PR fixes:

Fixes #6206

Special notes for your reviewer:

…ommand

The flag was implemented in #3096.
The logic that respects the flag was removed in e54d1b5,
likely by accident.
This commit restores the logic that prevents dependency resolution if the corresponding flag is set.
@vvagaytsev vvagaytsev marked this pull request as ready for review June 25, 2024 11:14
@vvagaytsev vvagaytsev requested review from edvald and twelvemo June 25, 2024 11:14
Copy link
Collaborator

@twelvemo twelvemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vvagaytsev vvagaytsev added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit f12c8ab Jun 25, 2024
40 checks passed
@vvagaytsev vvagaytsev deleted the fix/pulumi-skip-dependencies-flag branch June 25, 2024 11:47
vvagaytsev added a commit that referenced this pull request Jun 25, 2024
A follow-up fix for #6226.
It returns the current task itself if the deps as skipped.
github-merge-queue bot pushed a commit that referenced this pull request Jun 25, 2024
…on (#6229)

* fix(pulumi): fix process deps resolution

A follow-up fix for #6226.
It returns the current task itself if the deps as skipped.

* refactor: extract local var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.13: [Bug]: --skip-dependencies is not working correctly with garden plugins pulumi preview command
2 participants