fix: handling varfiles in remote actions #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManAnRuck
force-pushed
the
helm-source-varfiles
branch
from
be50da1 to
6abf4c6
Compare
|
@ManAnRuck thank you so much for creating the PR! 👍 I'll take a closer look soon. Let's bring this together to the next release :) |
|
i am currently thinking about what is a better solution.
any suggestions or other ideas? |
ManAnRuck
changed the title
ManAnRuck
changed the title
Signed-off-by: Manuel Ruck <[email protected]>
Signed-off-by: Manuel Ruck <[email protected]>
vvagaytsev
force-pushed
the
helm-source-varfiles
branch
from
5172cfc to
a9e3457
Compare
vvagaytsev
changed the title
|
@ManAnRuck thanks for the fix! LGTM 👍 @stefreak @thsig can you take a look please? I've added a few more changes to the PR. |
|
Thank you :) then I will try now to reuse this function to get the valueFiles too 😃 |
stefreak
reviewed
Jun 11, 2024
| @@ -5,6 +5,10 @@ source: | |||
| repository: | |||
| url: https://github.com/garden-io/garden-example-remote-module-jworker.git#main | |||
|
|
|||
| # Do not delete, this must be resolved from the current path, not from the cloned sourced path | |||
| varfiles: | |||
| - ./.env | |||
There was a problem hiding this comment.
@vvagaytsev I just noticed this is an example, and not a test case– examples should be concise and this comment might confuse new users. Maybe it's better to create a more specific integ or unit test for this behaviour and remove this code from the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix read varfiles in helm deployments with
sources.repository.urlWhich issue(s) this PR fixes:
Fixes #6146
Special notes for your reviewer:
It's just a dirty try to fix it. maybe there are some better solutions